Chore: Fix eslint usage #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
added
type/dependencies
Clarity-89
approved these changes
Oct 4, 2021
Comment on lines
+48
to
+49
| "eslint-plugin-react": "^7.26.1", | ||
| "eslint-plugin-react-hooks": "^4.2.0", |
There was a problem hiding this comment.
Not sure we need these since we're not using react here, the same goes for jsdoc plugin.
There was a problem hiding this comment.
I agree, we don't really need them, but they are required when using this "extends": ["@grafana/eslint-config"].
I honestly wondered if it was worth it or if we should use our own config and preferred to use the Grafana config and keep these extra dependencies. WDYT?
There was a problem hiding this comment.
Ah I see, I guess we can keep these extra dependencies, they're dev dependencies anyways, so we don't need to maintain a separate config for the image renderer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslintinto dev dependencies@grafana/eslint-configinstead of having plugin ruleseslintusage