m1 #318
Merged
m1 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturWierzbicki
added a commit
that referenced
this pull request
Jan 26, 2022
* allow scaled thumbnails * added support for full page images * add `acceptBeforeUnload` handler * use png files * produce requested thumbnail size * Update src/browser/browser.ts Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com> * review fix: move variable away from misleading comment * review fix: added default `headed` option to the default and dev env files * review fix: removed ternary expression * review fix: remove `withFullPageViewport` * review fix: fixed full page screenshots for non-kiosk mode * add script downloading platform-specific sharp binary * update yarnlock * fix package_Target script * update circleci node version * update package json * fix package.json -> pkg.assets paths * downgrade pkg to fix sharp build issue * working m1 (#318) * replace `mkdir -p` with `fs.mkdirSync {recursive: true}` * Update scripts/download_sharp.js Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com> * Update scripts/download_sharp.js Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com> * Update scripts/package_target.sh Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com> Co-authored-by: Artur Wierzbicki <artur@arturwierzbicki.com> Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com> Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.