Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set captureBeyondViewport to false by default #335

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Set captureBeyondViewport to false by default #335

merged 2 commits into from
Mar 14, 2022

Conversation

AgnesToulet
Copy link
Contributor

Fix old alert list panel rendering (before Grafana 8 and React migration) by setting the captureBeyondViewport screenshot option to false by default.

spinillos
spinillos approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@spinillos spinillos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was tested with 7.5.1 and current Grafana version and Alert list works in both with this change.

@AgnesToulet AgnesToulet merged commit 029122a into master Mar 14, 2022
@AgnesToulet AgnesToulet deleted the fix-old-panel-rendering branch March 14, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spinillos spinillos spinillos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgnesToulet @spinillos