Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when req.failure() is null #403

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix error when req.failure() is null #403

merged 2 commits into from
Feb 10, 2023

Conversation

spinillos
Copy link
Member

Related: https://github.com/grafana/support-escalations/issues/5010

Looks like that req.failure() could be null and it fails when it happens.

src/browser/browser.ts Outdated Show resolved Hide resolved
@spinillos spinillos merged commit 5686d65 into master Feb 10, 2023
@spinillos spinillos deleted the check-null-error branch February 10, 2023 11:10
@Bujupah
Copy link
Contributor

Bujupah commented Feb 27, 2023

Hmm I raised an issue #381 and a fix #379 days ago but it did not got merged haa 😒😒😒
Just kidding, thanks for fixing it ♥. I will be closing both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants