Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unused dependencies #517

Merged
merged 4 commits into from
May 6, 2024

Conversation

evictorero
Copy link
Contributor

@evictorero evictorero commented Apr 24, 2024

This is an attempt to remove unused dependencies and simplify keeping dependencies updated and the project in a good health.
I've used depcheck to evaluate and remove unused dependencies.

  • remove google-protobuf from dependencies
  • remove a bunch of dev dependencies including superagent which has CVE-2022-29622
  • bump supertest to fix CVE-2022-29622

I've run integration tests, manual tests and scripts for build, lint and test.

@juanicabanas
Copy link
Contributor

When installing the dependencies, I get a warning
poolpeteer@0.23.3" has incorrect peer dependency "puppeteer@^13.1.1"
I think we should take a look

@evictorero
Copy link
Contributor Author

When installing the dependencies, I get a warning poolpeteer@0.23.3" has incorrect peer dependency "puppeteer@^13.1.1" I think we should take a look

I found this
Running yarn install --pure-lockfile removed this warning in my local instance.

@AgnesToulet AgnesToulet merged commit 578d492 into master May 6, 2024
4 checks passed
@AgnesToulet AgnesToulet deleted the evictorero/chore-remove-unused-dependencies branch May 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants