Full page image: Fix wait condition for dashboard with rows #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
requested review from
a team,
juanicabanas and
evictorero
and removed request for
a team
evictorero
approved these changes
Jul 12, 2024
|
Ah good catch, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the wait condition for dashboards with rows as it's been broken since this change.
I know that relying on the
data-testidis not great, but the test should alert us sooner next time (this should ideally also be covered by an E2E test in Grafana), and this condition is only used when dashboards are not rendered with Scenes (it will be removed when we stop supporting legacy dashboards).