Remote rendering: Improve error handling, logging and metrics #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had completely screwed up the exception handling when running as HTTP service, basically swallowed the exception and tried to log it, but the logger was badly implemented. This is the reason why metrics only showed 200 response statuses and nothing else :)
Changes:
the http_request_duration_seconds_* metrics instead of 200.
499 is a non-standard code and is used by Nginx and I think
it's okay to use this here since the code is not returned
to any client.