Adds UserAgent and CPU Usage optimization #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
briangann
commented
Mar 24, 2023
briangann
commented
- Updates packages
- Add GrafanaKiosk to user agent string with build version
- Adds build version to output
- Reduces CPU usage of application
gaetanars
reviewed
Mar 24, 2023
README.md
Outdated
| KIOSK_IS_PLAYLIST bool | ||
| URL is a playlist (default "false") | ||
| KIOSK_LOGIN_METHOD string | ||
| [anon|local|gcom|goauth|idtoken|apikey] (default "anon") | ||
| [anon|local|gcom|goauth|idtoken] (default "anon") |
There was a problem hiding this comment.
Why do you remove the apikey value from the doc?
There was a problem hiding this comment.
my mistake - merge failure, will add it back, thanks for the catch!
There was a problem hiding this comment.
i took the output from the command-line help output, looks like the option wasn't added to the env section. i've added it back in. thanks again!
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 8f2ceae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 2.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 3.4%. View more on Code Climate. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.