Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing of scale factor #142

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fix passing of scale factor #142

merged 1 commit into from
Sep 22, 2024

Conversation

maximoei
Copy link
Contributor

@maximoei maximoei commented Aug 22, 2024 •
edited
Loading

Pass scale factor if used as a command line variable. Currently, -scale-factor is accepted as a command line variable, but not properly passed to the config and therefore not applied.

@maximoei
Fix passing of scale factor
88b340b 
Pass scale factor if used as a command line variable
@CLAassistant
Copy link

CLAassistant commented Aug 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@briangann
Copy link
Collaborator

good catch!

@briangann briangann self-requested a review September 22, 2024 03:29
@briangann briangann self-assigned this Sep 22, 2024
@briangann briangann added the bug Something isn't working label Sep 22, 2024
@briangann briangann merged commit f3b68e3 into grafana:main Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangann briangann Awaiting requested review from briangann

Assignees

@briangann briangann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximoei @CLAassistant @briangann