Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload chrome tab when it crashes (e.g. out of JS memory) #15

Merged
merged 1 commit into from
Dec 20, 2019
Merged

reload chrome tab when it crashes (e.g. out of JS memory) #15

merged 1 commit into from
Dec 20, 2019

Conversation

m-ronchi
Copy link
Contributor

@m-ronchi m-ronchi commented Nov 7, 2019

Workaround for a panel we use that may have a memory leak, causing chrome to kill the tab with the dashboard after some time.

This will listen to the chromedp inspector.EventTargetCrashed event and reloads the tab.

I can add a cli flag for enabling this behaviour if you prefer

@briangann briangann self-requested a review December 20, 2019 09:32
@briangann briangann self-assigned this Dec 20, 2019
@briangann briangann added the enhancement New feature or request label Dec 20, 2019
@briangann briangann merged commit df088cd into grafana:master Dec 20, 2019
@briangann
Copy link
Collaborator

excellent thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangann briangann Awaiting requested review from briangann

Assignees

@briangann briangann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-ronchi @briangann