ClickHouse Database datasource plugin update to 2.3.1

[Slach]

2.3.1 (2021-04-23)

Breaking changes

• On latest Grafana 7.x releases, template variables SQL queries shall return only scalar types of values, see Grafana 7.4.2 Variables query using clickhouse groupArray() dosn't working Altinity/clickhouse-grafana#328

Enhancement:

• add support Apple M1 ;)
• switch to new grafana plugin Golang SDK, thanks to @bmanth60 and @valeriakononenko for help
• add BasicAuth support for alerts, see Support Basic Auth for datasource which used BasicAuth for alerts Altinity/clickhouse-grafana#267

Fixes:

• fix github actions backend build
• fix UNION ALL parsing, see Union ALL + WITH: Syntax error (1.9.5 -> 2.2.0) Altinity/clickhouse-grafana#319
• fix many issues with alerting
  • alert :the query was executed at an incorrect time Altinity/clickhouse-grafana#305
  • RawQuery cause time condition using from / to useless Altinity/clickhouse-grafana#327
  • rawQuery passed to backend part with $template_variable Altinity/clickhouse-grafana#334
  • golang part of plugin incorrect handle empty (rows=0) results from Clickhouse Altinity/clickhouse-grafana#335

Signed-off-by: Eugene Klimov eklimov@altinity.com

[Slach]

@marcusolsson could you look to this PR ?
why PR still not merged? why process so complicated and continue more than 1 month?

[daniellee]

I have a question about the Yandex.Cloud authorization headers. The X-ClickHouse-Key field is saved in jsonData (clear text) and it is easy to see the value for it in the network request. Is this a credential that should be saved in secureJsonData and added as a header on the backend instead?

It is used on the backend here: https://github.com/Vertamedia/clickhouse-grafana/blob/master/pkg/client.go#L52 but also on the frontend: https://github.com/Vertamedia/clickhouse-grafana/blob/master/src/datasource.ts#L84

[Slach]

@daniellee I can prepare secureJson PR with different release
is it required to merge PR?

[daniellee]

Sounds like a plan as this is not part of this change and was introduced a long time ago. Will merge this and then you can follow up with the fix.

[Slach]

@daniellee thanks a lot, I promise a next release will try to use secureJSON for X-Auth-Key and X-ClickHouse-User on frontend and backend part

[daniellee]

Lots of changes in this release. The new authentication changes look good. While going through the code noticed that the frontend does not handle the Yandex API key in a secure way and that will need to be fixed in the near future.