Fix: only build middleware chain once #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
njvrzm
force-pushed
the
njvrzm/build-middlewares-once
branch
from
90a1b27 to
ea54e11
Compare
grafana-plugins-platform-bot
bot
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
Contributor
Author
|
The "incompatible changes" error is a red herring btw - I changed some receivers from value to pointer because there were inconsistent receiver types. We're returning a pointer anyway. The only way this could end up being incompatible is if someone's calling I can revert the receiver type changes, though, if there's any objection. |
wbrowne
approved these changes
Nov 24, 2025
github-project-automation
bot
moved this from 🔬 In review
to 🚀 Shipped
in Plugins Platform / Grafana Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes
MiddlewareHandlerto build its middleware chain once when instantiated rather than doing it for each request. TheHandlerreturned byhandlerFromMiddlewareswill be functionally identical any time it's called; calling it once will save a lot of allocations, although since this way is also simpler and more readable I haven't actually tried to benchmark it.