-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build for Linux on Arm64 #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryantxu @marefr @kylebrandt What do you think about including ARM64 as a Mage target?
Should it be built by default (as the PR proposes)?
Are all default build targets included into plugin package that is installed with Maybe it's not the right place to ask, but I was wondering why, say, on ARM64 machine I also get all other binaries? |
@gytisrepecka It depends on how the individual plugin is packaged, but I don't see any reason at least why other architectures should get installed. For grafana-image-renderer f.ex. I only get Linux/AMD64 installed. Here we're just talking about building, not packaging. |
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM -- yes, the packaging discussion is different, the first step is having it build
thank you @mikhailredis! |
What this PR does / why we need it:
You can run Grafana on arm64 and should be able to run backend plugins.
Maybe we should include darwin on arm64 to be ready for the upcoming Mac?
Which issue(s) this PR fixes:
Fixes #220
Special notes for your reviewer:
Tested on Khadas VIM3 Pro!