Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build for Linux on Arm64 #221

Merged
merged 4 commits into from
Aug 21, 2020
Merged

Add build for Linux on Arm64 #221

merged 4 commits into from
Aug 21, 2020

Conversation

mikhail-vl
Copy link
Contributor

@mikhail-vl mikhail-vl commented Aug 21, 2020

What this PR does / why we need it:

You can run Grafana on arm64 and should be able to run backend plugins.
Maybe we should include darwin on arm64 to be ready for the upcoming Mac?

Which issue(s) this PR fixes:

Fixes #220

Special notes for your reviewer:

Tested on Khadas VIM3 Pro!

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryantxu @marefr @kylebrandt What do you think about including ARM64 as a Mage target?

Should it be built by default (as the PR proposes)?

build/common.go Outdated Show resolved Hide resolved
build/common.go Outdated Show resolved Hide resolved
@aknuds1 aknuds1 added the enhancement New feature or request label Aug 21, 2020
@gytisrepecka
Copy link

@ryantxu @marefr @kylebrandt What do you think about including ARM64 as a Mage target?

Should it be built by default (as the PR proposes)?

Are all default build targets included into plugin package that is installed with grafana-cli plugins install?

Maybe it's not the right place to ask, but I was wondering why, say, on ARM64 machine I also get all other binaries?

@aknuds1
Copy link
Contributor

aknuds1 commented Aug 21, 2020

@gytisrepecka It depends on how the individual plugin is packaged, but I don't see any reason at least why other architectures should get installed. For grafana-image-renderer f.ex. I only get Linux/AMD64 installed.

Here we're just talking about building, not packaging.

mikhail-vl and others added 2 commits August 21, 2020 06:50
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
@mikhail-vl mikhail-vl requested a review from aknuds1 August 21, 2020 13:53
@aknuds1 aknuds1 dismissed their stale review August 21, 2020 13:56

It was fixed.

Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM -- yes, the packaging discussion is different, the first step is having it build

@ryantxu ryantxu merged commit 1c0bc4e into grafana:master Aug 21, 2020
@mikhail-vl mikhail-vl deleted the feat/arm64 branch August 21, 2020 15:58
@ryantxu
Copy link
Member

ryantxu commented Aug 21, 2020

thank you @mikhailredis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Linux on arm64 platform
4 participants