Skip to content

Commit

Permalink
Don't set alert styles for react panels, fix #823
Browse files Browse the repository at this point in the history
  • Loading branch information
alexanderzobnin committed Oct 28, 2019
1 parent ca50d0d commit 42d93b4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/datasource-zabbix/zabbixAlerting.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ class ZabbixAlertingService {
});
}

if (panelIndex >= 0) {
// Don't apply alert styles to .panel-container--absolute (it rewrites position from absolute to relative)
if (panelIndex >= 0 && !panelContainers[panelIndex].className.includes('panel-container--absolute')) {
let alertClass = "panel-has-alert panel-alert-state--ok panel-alert-state--alerting";
$(panelContainers[panelIndex]).removeClass(alertClass);

Expand Down

5 comments on commit 42d93b4

@maxlehot1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to implement this change, restart the grafana server and still doesn't work, but the change was "set" in the zabbixAlerting.service.js file even after the restart...

Its like if the grafana-server/zabbix plugin doesn't take the new file.

Do you have an idea for that so I can start working correctly with Bar Gauge ?

Thanks again

@maxlehot1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderzobnin Any idea?

@maxlehot1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything @alexanderzobnin

@maxlehot1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try a lot of option and still doesn't change anything cause of the Element.Style that override something.
I think that the ElementStyle comes from Grafana...

Well, I will wait an update in 2020 (I hope) :(

@maxlehot1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.