Rewritten ptototype.query method #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method now uses the same request doZabbixAPIRequest without code dublication. Please check on your installation cause I have only one metric per graph
|
Alex, is it possible in grafana by default replace word alias with the metric name from zabbix api, and add check box "autoupdate metric name from api" if it is set to true, than every time when graph is loaded to take metric name from api, not from alias field? |
|
It's good idea. I'll try to realize this feature later. |
alexanderzobnin
added a commit
that referenced
this pull request
May 8, 2015
Rewritten ZabbixAPIDatasource.prototype.query() method.
|
Have you fully tested this patch ? |
|
Yes, I check for errors and for my installation all right. if you see errors again, please open issue with detailed error description. |
Closed
alexanderzobnin
pushed a commit
that referenced
this pull request
Jul 27, 2017
Update direct-db-connection.md
2 tasks
3 tasks
leleobhz
referenced
this pull request
in ZenithTecnologia/grafana-zabbix
Jul 6, 2022
leleobhz
referenced
this pull request
in ZenithTecnologia/grafana-zabbix
Jul 6, 2022
leleobhz
referenced
this pull request
in ZenithTecnologia/grafana-zabbix
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method now uses the same request doZabbixAPIRequest without code
dublication. Please check on your installation cause I have only one
metric per graph
I thinl idea is clear to remove code dublication with auth, and do all requests thru doZabbixAPIRequest