Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Dependency clean up #1692

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Chore: Dependency clean up #1692

merged 9 commits into from
Sep 27, 2023

Conversation

zoltanbedi
Copy link
Member

@zoltanbedi zoltanbedi commented Sep 24, 2023

In this PR:

  • Removed some of the old CI stuff and scripts related to them
  • Updated create-plugin which made some changes in the .config folder
  • Removed the e2e dependencies and removed one test that was not really testing anything
  • Removed a couple of unused dependencies and bumped most of them to remove vulnerabilities
  • Converted zabbix.test.js to typescript
  • Removed some code in the jest-setup.js that were not needed anymore

@zoltanbedi zoltanbedi mentioned this pull request Sep 26, 2023
@zoltanbedi zoltanbedi requested review from a team, gabor and gwdawson and removed request for a team September 26, 2023 09:08
@zoltanbedi zoltanbedi self-assigned this Sep 26, 2023
jest.mock('grafana/app/core/core', () => ({
contextSrv: {},
}), {virtual: true});
jest.mock(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed because of prettier format

"minimatch": "^3.0.2",
"fstream": "^1.0.12"
}
"jackspeak": "2.1.1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to pin this dependency because of an issue in yarn 1. See storybookjs/storybook#22431 (comment) for more info.

@@ -48,7 +48,7 @@ services:
POSTGRES_DB: zabbix

database:
image: postgres
image: postgres:15
Copy link
Contributor

@gabor gabor Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are multiple devenv-docker-compose files with this postgres-entry.. do we want to fix all of them in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think that makes sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I had to bump this because postgres translates to the latest which is 16 and zabbix server shuts down with an error:
Unable to start Zabbix server due to unsupported PostgreSQL database version (16.0). Must not be higher than (15.x)

Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work. LGTM 👍

@zoltanbedi zoltanbedi requested a review from a team as a code owner September 26, 2023 15:32
@zoltanbedi
Copy link
Member Author

I wonder if @alexanderzobnin is ok with these changes?

@zoltanbedi zoltanbedi merged commit 4f69034 into master Sep 27, 2023
1 check passed
@zoltanbedi zoltanbedi deleted the zoltan/dependency-cleanup branch September 27, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants