Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for scenes framework #1822

Merged
merged 4 commits into from
Apr 29, 2024
Merged

fixes for scenes framework #1822

merged 4 commits into from
Apr 29, 2024

Conversation

yesoreyeram
Copy link
Collaborator

@yesoreyeram yesoreyeram commented Apr 22, 2024 •
edited
Loading

@yesoreyeram yesoreyeram requested a review from a team as a code owner April 22, 2024 08:49
gabor
gabor reviewed Apr 22, 2024
View reviewed changes
src/datasource/zabbix/proxy/cachingProxy.ts Outdated
return getHash(argsJson);
} catch (ex) {
console.error(`failing to get the request hash for caching. type of args ${typeof args}`);
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if it would be safer to return Math.random() or something similar here, because 0 will cause every such request to share the cache-key... WDYT?

@yesoreyeram yesoreyeram requested a review from gabor April 29, 2024 10:37
gabor
gabor approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yesoreyeram yesoreyeram merged commit 3ebc05d into main Apr 29, 2024
4 checks passed
@yesoreyeram yesoreyeram deleted the scenes-temp-workaround branch April 29, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor gabor gabor approved these changes

@zoltanbedi zoltanbedi Awaiting requested review from zoltanbedi zoltanbedi is a code owner automatically assigned from grafana/oss-big-tent

@gwdawson gwdawson Awaiting requested review from gwdawson gwdawson is a code owner automatically assigned from grafana/oss-big-tent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin is failing to render in new Scenes architecture
2 participants
@yesoreyeram @gabor