Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple UI fix: Indent dashboards inside the folder #11073

Closed
costimuraru opened this issue Mar 3, 2018 · 5 comments
Closed

Simple UI fix: Indent dashboards inside the folder #11073

costimuraru opened this issue Mar 3, 2018 · 5 comments
Assignees
@Ijin08
Labels
area/search type/ux
Milestone
5.1-beta1

Comments

@costimuraru
Copy link

Amazing work with the folders in Grafana 5.0! I have just a small suggestion regarding indentation.

Please include this information:

  • What Grafana version are you using?
    5.0
  • What datasource are you using?
    Graphite
  • What OS are you running grafana on?
    RedHat
  • What did you do?
    View dashboards and folders
  • What was the expected result?
    View dashboards indented inside the folder.
  • What happened instead?
    Dashboards and folders have the same indentation, making it hard to distinguish between the two and to group them visually.

Today:
noindent

Proposed version (with indentation):
withindent
@torkelo
Copy link
Member

torkelo commented Mar 3, 2018

might be a good idea, but the indentation seems a bit extreme :)

@torkelo
Copy link
Member

torkelo commented Mar 3, 2018

screen shot 2018-03-03 at 14 17 42

screen shot 2018-03-03 at 14 17 25

@costimuraru
Copy link
Author

costimuraru commented Mar 3, 2018 •
edited
Loading

That looks f'ing awesome, @torkelo!!! :D 🎉 🎈

@bergquist bergquist added this to the 5.1 milestone Mar 6, 2018
@Ijin08 Ijin08 mentioned this issue Mar 16, 2018
Merged
@martynd
Copy link

martynd commented Mar 19, 2018

Definitely an improvement like that.

With that said, I think simply switching the colors and box effect on the folder and dashboards around would do the trick.

As a rough demonstration I simply flipped the classes (which is why the styling looks a little off, but I think it still illustrates it well enough)

@bergquist
Copy link
Contributor

Closed by #11271

marefr added a commit that referenced this issue Apr 16, 2018
@marefr
changlelog: notes about closing issues/pr's
645658d 
#11053, #11252, #10836, #11185, #11168, #11332, #11391, #11073, #9342, #11001, #11183, #11211, #11384, #11095, #10792, #11138, 
#11516
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ijin08 Ijin08

Labels
area/search type/ux
Projects
None yet
Milestone
5.1-beta1
Development

No branches or pull requests
6 participants
@torkelo @bergquist @martynd @costimuraru @marefr @Ijin08