Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Should enable "Save As" when a user with viewer role has edit permission in another folder #11625

Closed
bergquist opened this issue Apr 17, 2018 · 1 comment
Closed

[Feat] Should enable "Save As" when a user with viewer role has edit permission in another folder #11625

bergquist opened this issue Apr 17, 2018 · 1 comment
Assignees
@marefr
Labels
area/dashboard area/permissions type/feature-request
Milestone
5.2.0-beta1

Comments

@bergquist
Copy link
Contributor

bergquist commented Apr 17, 2018 •
edited
Loading

It's common that users copy each other's dashboards to get started or make minor changes that meet their own requirements. Not being able to use Save as dashboard as a viewer is a big limitation for some organizations.

When users load a dashboard the backend should query the database and see if the user is editor in any folders. If that the case, Grafana should enable the user to use Save As and give the user a modal asking for which folder the dashboard should be saved in.
@marefr marefr self-assigned this Apr 17, 2018
@bergquist bergquist changed the title Should be use "Save As" as a viewer. Should be able to use "Save As" as a viewer. Apr 17, 2018
@marefr marefr changed the title Should be able to use "Save As" as a viewer. [Feat] Should be able to use "Save As" as a viewer Apr 17, 2018
@marefr marefr removed their assignment Apr 17, 2018
@shalstea
Copy link

+1

@marefr marefr added this to the 5.2 milestone Apr 25, 2018
@marefr marefr changed the title [Feat] Should be able to use "Save As" as a viewer [Feat] Should enable "Save As" as when viewers_can_edit are enabled Apr 25, 2018
@torkelo torkelo changed the title [Feat] Should enable "Save As" as when viewers_can_edit are enabled [Feat] Should enable "Save As" when a user with viewer role has edit permission in another folder Apr 25, 2018
@marefr marefr self-assigned this Apr 30, 2018
@marefr marefr mentioned this issue Apr 30, 2018
Merged
marefr added a commit that referenced this issue May 2, 2018
@marefr
changelog: add notes about closing #11625
6dcb9e6 
[skip ci]
ryantxu added a commit to NatelEnergy/grafana that referenced this issue May 4, 2018
@ryantxu
Merge remote-tracking branch 'grafana/master'
6462601 
* grafana/master:
  Revert "Opportunities to unindent code (unindent)"
  changelog: add notes about closing grafana#11625
  remove jest it.only to not skip important tests
  --amend
  fix: improved handling of http server shutdown
  dashboard: show save as button if can edit and has edit permission to folders
  new property for current user indicating if edit permissions in folders
  Use opportunities to unindent code (unindent)
@IntegersOfK IntegersOfK mentioned this issue Jun 26, 2018
Closed
@marefr marefr mentioned this issue Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marefr marefr

Labels
area/dashboard area/permissions type/feature-request
Projects
None yet
Milestone
5.2.0-beta1
Development

No branches or pull requests
3 participants
@bergquist @marefr @shalstea