Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard exporter doesn't add datasource template var dependency #13891

Closed
DanCech opened this issue Oct 29, 2018 · 2 comments · Fixed by #13990
Closed

Dashboard exporter doesn't add datasource template var dependency #13891

DanCech opened this issue Oct 29, 2018 · 2 comments · Fixed by #13990
Labels
Milestone

Comments

@DanCech
Copy link
Collaborator

DanCech commented Oct 29, 2018

When exporting a dashboard that uses a "data source" template variable, the data source type is not added to the __requires list in the exported JSON, which means that it doesn't get categorized correctly on grafana.com

@torkelo
Copy link
Member

torkelo commented Oct 29, 2018

maybe we can fix this same time we fix this, #13781 which is unrelated but touching the exporter. Would like your feedback on that one actually. A lot of people having issues with the export format that is specific for sharing dashboards and not compatible with provisioning and direct dashboard save/update API usage so thinking of adding checkbox to export modal that will be called something like "For sharing on grafana.com" which will turn on the templatizing & adding of inputs & requires. This checkbox will be turned off by default.

@torkelo torkelo added this to the 5.4 milestone Oct 29, 2018
torkelo added a commit that referenced this issue Nov 7, 2018
@torkelo
Copy link
Member

torkelo commented Nov 7, 2018

fixed in #13990

@torkelo torkelo modified the milestones: 5.4, 5.3.4 Nov 7, 2018
ryantxu added a commit to ryantxu/grafana that referenced this issue Nov 9, 2018
* grafana/master: (116 commits)
  Adjust UI depth of query statistics
  Preserve suffix text when applying function suggestion
  changelog: adds note about closing grafana#13993
  Refactored log stream merging, added types, tests, comments
  Fixes grafana#13993 - adds more options for Slack notifications
  add auth.proxy headers to sample.ini
  add auth.proxy headers to default.ini
  fixed issue with reducer sharing url query instance with angular router
  fixed exporter bug missing adding requires for datasources only used via data source variable, fixes grafana#13891
  minor text change in export modal
  build: removes unused.
  Fixed issues introduced by changing to PureComponent
  further refactoring of grafana#13984
  minor fix
  refactorings and some clean-up / removal of things not used
  Update docs/sources/permissions/dashboard_folder_permissions.md
  Fix typo in docs/sources/reference/scripting.md
  move enterprise down in menu
  wip: panel-header: Fix shareModal compatibility with react and angular
  wip: panel-header: Remove custom menu items from panels completely
  ...
ryantxu added a commit to ryantxu/grafana that referenced this issue Nov 10, 2018
* grafana/master: (1208 commits)
  Adjust UI depth of query statistics
  Preserve suffix text when applying function suggestion
  changelog: adds note about closing grafana#13993
  Refactored log stream merging, added types, tests, comments
  Fixes grafana#13993 - adds more options for Slack notifications
  add auth.proxy headers to sample.ini
  add auth.proxy headers to default.ini
  fixed issue with reducer sharing url query instance with angular router
  fixed exporter bug missing adding requires for datasources only used via data source variable, fixes grafana#13891
  minor text change in export modal
  build: removes unused.
  Fixed issues introduced by changing to PureComponent
  further refactoring of grafana#13984
  minor fix
  refactorings and some clean-up / removal of things not used
  Update docs/sources/permissions/dashboard_folder_permissions.md
  Fix typo in docs/sources/reference/scripting.md
  move enterprise down in menu
  wip: panel-header: Fix shareModal compatibility with react and angular
  wip: panel-header: Remove custom menu items from panels completely
  ...
bergquist pushed a commit to bergquist/grafana that referenced this issue Nov 12, 2018
…via data source variable, fixes grafana#13891

(cherry picked from commit 99610e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants