(cloudwatch) support high resolution query #10925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtanda
force-pushed
the
cw_high_resolution
branch
from
999eaf7
to
18c54a9
Compare
|
I want to more good option name. "highResolution" is not good... |
Codecov Report
@@ Coverage Diff @@
## master #10925 +/- ##
==========================================
- Coverage 51.47% 51.45% -0.03%
==========================================
Files 343 343
Lines 24244 24258 +14
Branches 1417 1417
==========================================
+ Hits 12480 12482 +2
- Misses 11069 11081 +12
Partials 695 695 |
|
LGTM, regarding name I also cannot come up with a good name for the setting. |
|
@mtanda also thanks for looking into this I tried it locally but ran out of time |
bergquist
requested changes
Mar 7, 2018
pkg/tsdb/cloudwatch/cloudwatch.go
Outdated
| @@ -274,6 +293,11 @@ func parseQuery(model *simplejson.Json) (*CloudWatchQuery, error) { | |||
| alias = "{{metric}}_{{stat}}" | |||
| } | |||
|
|
|||
| highResolution, err := model.Get("highResolution").Bool() | |||
There was a problem hiding this comment.
When I test this PR I get an error.
This should be .MustBool(false)
There was a problem hiding this comment.
Thanks for check!
Fix it.
bergquist
approved these changes
Mar 8, 2018
|
Awesome! :) Great work |
bergquist
added a commit
that referenced
this pull request
Mar 8, 2018
|
Thanks!! |
|
I can't find info in the docs about the "HighRes" checkbox. What does it actually do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9246
@igorleao
@mauve