Graph: Fixed series legend color for hidden series #16438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom grayscale, replaced colors for linkDisabled and linkHover with colors from grayscale, changed color for sha-modal-in-text to text-color-empahises
torkelo
changed the title
torkelo
pushed a commit
that referenced
this pull request
Apr 8, 2019
* replaced colors for headingColor, link and linkDisabled with colors from grayscale, replaced colors for linkDisabled and linkHover with colors from grayscale, changed color for sha-modal-in-text to text-color-empahises * fixed snapshot (cherry picked from commit 70dcb6a)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Apr 9, 2019
* grafana/master: (27 commits) docs: fixes and update current version Docs: Updated changelog for v6.1.3 Graph: fixed png rendering with legend to the right (grafana#16463) Fix: Disables auto open datasource picker on focus (grafana#16398) add some mock/stub guidelines to testing guideline (grafana#16466) Feat: Suggestion list in Explore is virtualized (grafana#16342) Docs: Updated roadmap issue to link to the pinned roadmap issues Graph: Fixed auto decimals in legend values (grafana#16455) Styling: Aligned heading (grafana#16456) add PromQL keyword for adhoc filter (grafana#16426) Singlestat: Use decimal override when manually specified (grafana#16451) Graph: follow-up graph decimals fix, grafana#16414 (grafana#16450) Chore: use remote cache instead of session storage (grafana#16114) Docs: Minor changelog tweak Docs: Updated changelog with v6.1.2 release issues datasource: fix disable query when using mixed datasource (grafana#16409) Graph: Fixed series legend color for hidden series (grafana#16438) Templating: Fixed loading React variable query editor (grafana#16439) Styles: Fixed left menu highlight (grafana#16431) Fix: remove test artefact (grafana#16411) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating a bug with link colors I saw that they used lighten/darken instead of colors from the gray scale. So I replaced colors for headingColor, link and linkDisabled in dark theme and colors for linkDisabled and linkHover in light theme with colors from grayscale. I also changed color for strong in share-modal-in-text to text-color-empahises.
fixes #16432