Chore: remove use of == false
#17036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergquist
approved these changes
May 13, 2019
torkelo
approved these changes
May 14, 2019
Interestingly enough, golint or revive doesn't not prohibit the use that construction :) Ref #17035
markelog
force-pushed
the
dont-use-==false
branch
from
bfb76ea to
de46120
Compare
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 14, 2019
* grafana/master: Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064) serverlock: run tests async should be more linear time wise (grafana#17059) InfoPopover: Fixes transclude undefined error (grafana#17063) Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055) fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057) Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974) Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054) Docs: adds note about removing session storage (grafana#17003) Chore: remove use of `== false` (grafana#17036) Explore: use @grafana/ui legend (grafana#17027) tech: avoid alias for importing models in alerting (grafana#17041) DataSourcePlugin: support custom tabs (grafana#16859) Dashboard: Fixes scrolling issues for Edge browser (grafana#17033) SeriesData: remove color from Field (grafana#17044)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 14, 2019
* grafana/master: Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064) serverlock: run tests async should be more linear time wise (grafana#17059) InfoPopover: Fixes transclude undefined error (grafana#17063) Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055) fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057) Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974) Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054) Docs: adds note about removing session storage (grafana#17003) Chore: remove use of `== false` (grafana#17036) Explore: use @grafana/ui legend (grafana#17027) tech: avoid alias for importing models in alerting (grafana#17041) DataSourcePlugin: support custom tabs (grafana#16859) Dashboard: Fixes scrolling issues for Edge browser (grafana#17033) SeriesData: remove color from Field (grafana#17044)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 14, 2019
…-grafanaui * grafana/master: Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064) serverlock: run tests async should be more linear time wise (grafana#17059) InfoPopover: Fixes transclude undefined error (grafana#17063) Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055) fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057) Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974) Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054) Docs: adds note about removing session storage (grafana#17003) Chore: remove use of `== false` (grafana#17036) Explore: use @grafana/ui legend (grafana#17027) tech: avoid alias for importing models in alerting (grafana#17041) DataSourcePlugin: support custom tabs (grafana#16859) Dashboard: Fixes scrolling issues for Edge browser (grafana#17033) SeriesData: remove color from Field (grafana#17044)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 14, 2019
* grafana/master: (33 commits) Panels: Fixed alert icon position in panel header (grafana#17070) GraphPanel: use SeriesData directly (skip legacy transformation) (grafana#17037) Streaming: support streaming in MetricsPanelCtrl (grafana#17034) Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064) serverlock: run tests async should be more linear time wise (grafana#17059) InfoPopover: Fixes transclude undefined error (grafana#17063) Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055) fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057) Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974) Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054) Docs: adds note about removing session storage (grafana#17003) Chore: remove use of `== false` (grafana#17036) Explore: use @grafana/ui legend (grafana#17027) tech: avoid alias for importing models in alerting (grafana#17041) DataSourcePlugin: support custom tabs (grafana#16859) Dashboard: Fixes scrolling issues for Edge browser (grafana#17033) SeriesData: remove color from Field (grafana#17044) chore: remove x character in explore Dashboard: show refresh button in kiosk mode (grafana#17032) Devenv: Updated gauge test dashboard ...
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
May 15, 2019
* grafana/master: (25 commits) Chore: Bump jest to 24.8.0 (grafana#17094) Chore: Bump ts-node to 8.1.0 (grafana#17093) Release: Updated changelog backend: replace /pkg/errors with errutil (grafana#17065) Explore: Fixes filtering in Prometheus queries when clicking in Table (grafana#17083) Remotecache: Avoid race condition in Set causing error on insert. (grafana#17082) Build: Support publishing MSI to grafana.com (grafana#17073) InputDataSource: better empty value support (grafana#17075) Panels: Fixed alert icon position in panel header (grafana#17070) GraphPanel: use SeriesData directly (skip legacy transformation) (grafana#17037) Streaming: support streaming in MetricsPanelCtrl (grafana#17034) Gauge: Fix switching orientation issue when switching from BarGauge to Gauge (grafana#17064) serverlock: run tests async should be more linear time wise (grafana#17059) InfoPopover: Fixes transclude undefined error (grafana#17063) Dashboard: Fixes lazy loading & expanding collapsed rows on mobile (grafana#17055) fix: Azure Monitor adds missing closing div tag to query editor (grafana#17057) Chore: Use executable dir instead of pwd in CLI for isDev check (grafana#16974) Search: Set element height to 100% to avoid Chrome 74's overflow (grafana#17054) Docs: adds note about removing session storage (grafana#17003) Chore: remove use of `== false` (grafana#17036) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly enough, golint or revive doesn't not prohibit
the use that construction :)
Ref #17035