Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Image rendering #19183

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Docs: Image rendering #19183

merged 1 commit into from
Sep 17, 2019

Conversation

marefr
Copy link
Contributor

@marefr marefr commented Sep 17, 2019

What this PR does / why we need it:
Adds a new "Image Rendering" page in Administration section.
Updates configuration page with rendering settings and also default.ini and sample.ini.
Updates and cleanup pages that referencing image rendering.

Which issue(s) this PR fixes:
Ref #18914

Special notes for your reviewer:
See it as a draft. Was tricky to get something holding together, but would need feedback.
Do we call it external image render or remote image renderer?

@marefr marefr requested a review from torkelo September 17, 2019 15:15
@marefr marefr added this to the 6.4.0-beta2 milestone Sep 17, 2019
@marefr marefr added the type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project label Sep 17, 2019
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job!

@marefr marefr merged commit 75bf31b into master Sep 17, 2019
@marefr marefr deleted the docs_image_renderer branch September 17, 2019 17:24
ryantxu added a commit to ryantxu/grafana that referenced this pull request Sep 17, 2019
* grafana/master: (23 commits)
  API: adds redirect helper to simplify http redirects (grafana#19180)
  docs: image rendering (grafana#19183)
  Chore: Update latest.json (grafana#19177)
  Chore: Update version to next (grafana#19169)
  Docs: What's new in 6.4 update (grafana#19175)
  Devenv: create slow_proxy_mac (grafana#19174)
  Chore: Changelog for v6.4.0-beta1 (grafana#19171)
  Revert "Chore: Update Slate to 0.47.8 (grafana#18412)" (grafana#19167)
  Chore: Update Slate to 0.47.8 (grafana#18412)
  Changelog: Breaking changes and deprecation notes for v6.4 (grafana#19164)
  Docs: What's new 6.4 draft (grafana#19144)
  Docs: Add docs around feature toggles config (grafana#19162)
  Azure Monitor: Add support for cross resource queries (grafana#19115)
  Api: Readonly datasources should not be created via the API (grafana#19006)
  Explore: Update live tail buttons (grafana#19143)
  LDAP: only show tab if LDAP is enabled (grafana#19156)
  TimePicker: Fixes onBlur issue with FireFox on MacOS (grafana#19154)
  Feature: Encapsulated dynamic imports with error boundary and suspense (grafana#19128)
  Metrics: Adds setting for turning off total stats metrics (grafana#19142)
  Add directions for more details provided when not anymore on issue triage (grafana#19116)
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request Sep 17, 2019
* grafana/master: (87 commits)
  API: adds redirect helper to simplify http redirects (grafana#19180)
  docs: image rendering (grafana#19183)
  Chore: Update latest.json (grafana#19177)
  Chore: Update version to next (grafana#19169)
  Docs: What's new in 6.4 update (grafana#19175)
  Devenv: create slow_proxy_mac (grafana#19174)
  Chore: Changelog for v6.4.0-beta1 (grafana#19171)
  Revert "Chore: Update Slate to 0.47.8 (grafana#18412)" (grafana#19167)
  Chore: Update Slate to 0.47.8 (grafana#18412)
  Changelog: Breaking changes and deprecation notes for v6.4 (grafana#19164)
  Docs: What's new 6.4 draft (grafana#19144)
  Docs: Add docs around feature toggles config (grafana#19162)
  Azure Monitor: Add support for cross resource queries (grafana#19115)
  Api: Readonly datasources should not be created via the API (grafana#19006)
  Explore: Update live tail buttons (grafana#19143)
  LDAP: only show tab if LDAP is enabled (grafana#19156)
  TimePicker: Fixes onBlur issue with FireFox on MacOS (grafana#19154)
  Feature: Encapsulated dynamic imports with error boundary and suspense (grafana#19128)
  Metrics: Adds setting for turning off total stats metrics (grafana#19142)
  Add directions for more details provided when not anymore on issue triage (grafana#19116)
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request Sep 19, 2019
* grafana/master: (39 commits)
  LDAP: Show non-matched groups returned from LDAP (grafana#19208)
  plugins: expose whole rxjs to plugins (grafana#19226)
  SQL: Rewrite statistics query (grafana#19178)
  CI: Update frontend ci metrics for strict null checks
  grafana/ui: Add disabled prop on LinkButton (grafana#19192)
  Cloudwatch: Fix autocomplete for Gamelift dimensions (grafana#19145) (grafana#19146)
  Backend: Remove redundant condition of `ROLE_VIEWER` (grafana#19211)
  FieldDisplay: Update title variable syntax (grafana#19217)
  Docs: Note when using For and No Data in alert rule (grafana#19185)
  Docker: Upgrade packages to resolve reported vulnerabilities (grafana#19188)
  MSSQL: Revert usage of new connectionstring format (grafana#19203)
  Prometheus: datasource config with custom parameters string (grafana#19121)
  Contributing: Add guidelines for contributing docs (grafana#19108)
  LDAP debug page: deduplicate errors (grafana#19168)
  Menu: fix menu button in the mobile view (grafana#19191)
  Dashboard: Fixes back button styles in kiosk mode (grafana#19165)
  API: adds redirect helper to simplify http redirects (grafana#19180)
  docs: image rendering (grafana#19183)
  Chore: Update latest.json (grafana#19177)
  Chore: Update version to next (grafana#19169)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants