Bring back scripts evaluation in TextPanel #26412
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26406
When html sanitization is disabled we need to process html against any inline script tag occurrences and eval those scripts to have an effect. React's
dangerouslySetInnerHTML
usesinnerHTML
which does not evaluate scripts: https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML@ryantxu I couldn't get the test for new logic to pass, any ideas? Seems like the parsed text is undefined in the test env, no idea why. Maybe some jsdom issue?