DataLinks: Respects display name and adds field quoting #27616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydelaney
approved these changes
Sep 16, 2020
Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>
torkelo
approved these changes
Sep 17, 2020
|
Great tests @hugohaggmark! |
hugohaggmark
added a commit
that referenced
this pull request
Sep 17, 2020
* DataLinks: Adds field quoting and respects DisplayName * Update public/app/features/panel/panellinks/link_srv.ts Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> (cherry picked from commit e86ff52)
This was referenced Sep 17, 2020
hugohaggmark
added a commit
that referenced
this pull request
Sep 17, 2020
* DataLinks: Adds field quoting and respects DisplayName * Update public/app/features/panel/panellinks/link_srv.ts Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> (cherry picked from commit e86ff52)
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
* DataLinks: Adds field quoting and respects DisplayName * Update public/app/features/panel/panellinks/link_srv.ts Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Firstly, this PR switches from using
field.nameto the actualdisplayNamefor the field. Secondly displayName containing.orWhich issue(s) this PR fixes:
Fixes #26545
Special notes for your reviewer: