Dashboard: Fixes kiosk state after being redirected to login page and back #29273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
papagian and
jessabe
and removed request for
a team
papagian
approved these changes
Nov 20, 2020
|
@papagian care to take another look. Pushed some additional tests for this |
papagian
approved these changes
Nov 20, 2020
torkelo
added
the
old backport v7.3.x
torkelo
changed the title
Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>
grafanabot
pushed a commit
that referenced
this pull request
Nov 20, 2020
… back (#29273) * Login: Fixes issue where url parameters where modified by golang url code * Add tests * Fix test cases * Update pkg/middleware/auth_test.go Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> * fixed formatting Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> (cherry picked from commit 1076f47)
torkelo
added a commit
that referenced
this pull request
Nov 20, 2020
… back (#29273) (#29278) * Login: Fixes issue where url parameters where modified by golang url code * Add tests * Fix test cases * Update pkg/middleware/auth_test.go Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> * fixed formatting Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> (cherry picked from commit 1076f47) Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
xlson
added a commit
to AgnesToulet/grafana
that referenced
this pull request
Nov 24, 2020
* master: (71 commits) Security: Fixes minor security issue with alert notification webhooks that allowed GET & DELETE requests grafana#29330 Chore: Bump storybook to v6 (grafana#28926) ReleaseNotes: Updates release notes link in package.json (master) (grafana#29329) Docs: Accurately reflecting available variables (grafana#29302) Heatmap: Fixes issue introduced by new eventbus (grafana#29322) Dashboard Schemas (grafana#28793) devenv: Add docker load test which authenticates with API key (grafana#28905) Login: Fixes redirect url encoding issues of # %23 being unencoded after login (grafana#29299) InfluxDB: update flux library and support boolean label values (grafana#29310) Explore/Logs: Update Parsed fields to Detected fields (grafana#28881) GraphNG: Init refactorings and fixes (grafana#29275) fixing a broken relref link (grafana#29312) Drone: Upgrade build pipeline tool (grafana#29308) decreasing frontend docs threshold. (grafana#29304) Docker: update docker root group docs and docker image (grafana#29222) WebhookNotifier: Convert tests away from goconvey (grafana#29291) Annotations: fixing so when changing annotations query links submenu will be updated. (grafana#28990) [graph-ng] add temporal DataFrame alignment/outerJoin & move null-asZero pass inside (grafana#29250) Dashboard: Fixes kiosk state after being redirected to login page and back (grafana#29273) make it possible to hide change password link in profile menu (grafana#29246) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26899
This fixes a bug in the golang query Values Encode function where it write "=" even for keys that have no value. A query parameter "&kiosk" is treated as a boolean true in the frontend but "&kiosk=" is treated as an empty string by the frontend.
A big hacky fix but since the bug is in the golang standard lib not sure what is best here.