Toolkit: Improve error messages when tasks fail #36381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
requested review from
a team,
jackw and
mckn
and removed request for
a team
dprokop
approved these changes
Jul 6, 2021
bryanuribe
pushed a commit
to open-o11y/grafana
that referenced
this pull request
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a command executed contains stdout, prefer to output that verbatim, rather than the Error object with that as a value. That way we can get pretty error messages from things like Typescript 😄
Before:
After:
Isn't that nice :)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: