Alerting: Increase test timeout #60445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
added
area/alerting
This comment was marked as resolved.
This comment was marked as resolved.
gillesdemey
force-pushed
the
alerting/increase-test-timeout-ruleeditorcloudrules
branch
from
dc3f2d9 to
1aca640
Compare
soniaAguilarPeiron
approved these changes
Dec 16, 2022
konrad147
approved these changes
Dec 16, 2022
gillesdemey
deleted the
alerting/increase-test-timeout-ruleeditorcloudrules
branch
This comment was marked as resolved.
This comment was marked as resolved.
grafanabot
added
the
backport-failed
This comment was marked as resolved.
This comment was marked as resolved.
|
Not back-porting these, since we've not back-ported the tests split either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
RuleEditorCloudRules.test.tsxseems to be flakey on CI – increasing the timeout of this particular test suite should help it pass the Drone CI.Why do we need this feature?
Ideally we wouldn't and we'd move these to e2e tests but setting up the correct testing environment is quite involved (judging by the amount of mocks that are involved in this test).
Special notes for your reviewer:
I'm increasing the timeout of this particular test instead of skipping it entirely, I hope this is an acceptable trade-off between confidence and patience.