API: Enable serving Swagger UI by default and add docs and guidelines #63489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be served behind the `swaggerUi` feature toggle.
papagian
added
no-backport
papagian
requested review from
joshhunt,
JoaoSilvaGrafana,
mckn,
sakjur,
mildwonkey and
yangkb09
and removed request for
a team
grafanabot
added
area/backend
area/frontend
type/docs
joshhunt
reviewed
Feb 21, 2023
|
(Open the links below in a new tab to go to the correct steps)
|
grafanabot
added
the
levitate breaking change
Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
chri2547
reviewed
Feb 23, 2023
There was a problem hiding this comment.
The feature toggles docs removal LGTM, so approved pending Engr approval. Including @josmperez to take a look at the addition to the dev docs. Thank you for the contribution!
josmperez
reviewed
Feb 23, 2023
josmperez
reviewed
Feb 23, 2023
josmperez
reviewed
Feb 23, 2023
josmperez
reviewed
Feb 23, 2023
josmperez
reviewed
Feb 23, 2023
josmperez
requested changes
Feb 23, 2023
|
@josmperez I made some changes following your review; can you check once again, thank you! |
josmperez
approved these changes
Mar 1, 2023
papagian
added
add to changelog
and removed
no-changelog
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
…#63489) * Enable serving Swagger UI by default It used to be served behind the `swaggerUi` feature toggle. * Remove `swaggerUi` feature toggle * Add docs and guidelines for updating swagger * Apply suggestions from code review Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
|
Please be advised that this feature loads stuff from unpkg.com, which to me is a third party. Both technical measures such as CSP, and legal measures such as the GDPR, may prevent this from working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
swaggerUifeature toggleWhy do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer: