Cloudwatch: Add MeteredIOBytes metric for EFS #64793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlagg5
requested review from
sarahzinger and
idastambuk
and removed request for
a team
|
|
grafanabot
added
area/backend
datasource/CloudWatch
pr/external
|
@xlagg5 thank you for your PR! Would you be able to sign our CLA so we might be able to merge this change? |
xlagg5
force-pushed
the
feature/add-MeteredIOBytes-metric-to-cloudwatch
branch
from
82cebee to
9b323b1
Compare
Done! |
sarahzinger
requested changes
Mar 21, 2023
There was a problem hiding this comment.
@xlagg5 thanks for signing the CLA! Taking a closer look and I'm wondering, does this work for you? It looks like it's under EC2Spot and not under EFS. Mind taking another look?
xlagg5
force-pushed
the
feature/add-MeteredIOBytes-metric-to-cloudwatch
branch
from
9b323b1 to
e4d92d3
Compare
Oh no! It was a mistake. Now it is fine. |
idastambuk
approved these changes
Mar 21, 2023
sarahzinger
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds missing metric from EFS Cloudwatch which is MeteredIOBytes.
Why do we need this feature?
We need this from improved CloudWatch plugin.
Who is this feature for?
For Cloudwatch EFS users.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer: