MegaMenu: Fixes mega menu showing scroll indicator when it shouldn't

[torkelo]

Fixes #65394

Noticed this hover indicator in the MenuMenu last couple of days.

This PR fixes

• Make sure the content expands to full height so we don't show the scroll indicator when we don't need to
• Fixes the position of the close button for mobile views (was not aligned with the topnav top section). Also adds a border bottom to the mega menu mobile header (so that it looks the same as the normal bottom half of topnav)

This is the bug I am seeing

Not sure if we should backport this or not? (as topnav is being rolled out more and more to cloud in 9.4.x ?)

[torkelo]

Not sure if we should backport this or not? (as topnav is being rolled out more and more to cloud in 9.4.x ?)

[joshhunt]

Fixes #65394 !! 🥳

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 27 existing alerts. Please check the repository Security tab to see all alerts.

[ashharrison90]

padding looks good 👍

but these changes regress showing the scroll indicator in mobile view. with the mobile header, setting height: 100% makes it taller than the screen so it doesn't work anymore 😢

i've never been able to repro the bug with the scroll indicator so i can't tell if this fixes it or not... i really hope it does 🤞 are there any specific steps you needed to take to see it? 🤔

[torkelo]

but these changes regress showing the scroll indicator in mobile view. with the mobile header, setting height: 100% makes it taller than the screen so it doesn't work anymore

@ashharrison90 ah, I was expecting that (and tried to replicate it but could not). will fix

[ashharrison90]

also re: backporting - i think we should, same as we would for any other bugfix 👍

[grafanabot]

Hello @torkelo!
Backport pull requests need to be either:

• Pull requests which address bugs,
• Urgent fixes which need product approval, in order to get merged,
• Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

[torkelo]

@ashharrison90 fixed the mobile issue, was easy standard flex fix :)

[ashharrison90]

looks great! 🥳

hope it fixes the issue for everyone 🤞