Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Rename remote.ExternalAlertmanager to remote.Alertmanager #76956

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Alerting: Rename remote.ExternalAlertmanager to remote.Alertmanager #76956

merged 1 commit into from
Oct 23, 2023

Conversation

santihernandezc
Copy link
Contributor

@santihernandezc santihernandezc commented Oct 23, 2023 •
edited
Loading

This PR renames structs and file names to avoid redundancy in names in the remote package.

  • .../remote/external_alertmanager.go -> .../remote/alertmanager.go
    • remote.ExternalAlertmanager -> remote.Alertmanager
    • remote.ExternalAlertmanagerConfig-> remote.AlertmanagerConfig
  • .../remote/external_alertmanager_test.go -> .../remote/alertmanager_test.go
    • TestNewExternalAlertmanager -> TestNewAlertmanager

@santihernandezc santihernandezc added area/alerting Grafana Alerting no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes kata:am_unify labels Oct 23, 2023
@santihernandezc santihernandezc added this to the 10.3.x milestone Oct 23, 2023
@santihernandezc santihernandezc requested review from a team, rwwiv, JacobsonMT, yuri-tceretian and grobinson-grafana and removed request for a team October 23, 2023 12:15
gotjosh
gotjosh approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santihernandezc santihernandezc merged commit 488a60a into main Oct 23, 2023
30 checks passed
@santihernandezc santihernandezc deleted the santihernandezc/rename_remote_external_alertmanager branch October 23, 2023 13:37
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotjosh gotjosh gotjosh approved these changes

@rwwiv rwwiv Awaiting requested review from rwwiv

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT

@yuri-tceretian yuri-tceretian Awaiting requested review from yuri-tceretian

@grobinson-grafana grobinson-grafana Awaiting requested review from grobinson-grafana

Assignees
No one assigned
Labels
area/alerting Grafana Alerting area/backend kata:am_unify no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Alerting
Archived in project
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@santihernandezc @gotjosh @aangelisc