Query Validation: accept any parser to validate query and integrate with Prom query editor #77081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-pr-automation
bot
added
datasource/Prometheus
area/frontend
datasource/Loki
labels
|
@grafana/observability-metrics Would you be interested in this feature? I wouldn't mind moving it elsewhere where other data sources could use this. |
matyax
added
no-backport
|
Backend code coverage report for PR #77081 |
|
Frontend code coverage report for PR #77081
|
|
This is a good refactor and a win IMO even if we don't pursue a shared lib |
matyax
changed the title
|
I agree @gtk-grafana, this looks good to me! |
bohandley
approved these changes
Oct 30, 2023
matyax
force-pushed
the
matyax/prom-validate-query
branch
from
c38c711
to
923c36d
Compare
matyax
added
add to changelog
no-changelog
|
Added unit tests for PromQL. Any concern about merging this @gtk-grafana @bohandley ? |
gtk-grafana
approved these changes
Oct 31, 2023
|
Thank you all! If there's any issue with this feel free to just ping 👍 |
79 tasks
bohandley
added a commit
that referenced
this pull request
Jan 29, 2024
…grate with Prom query editor
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of components in common, with similar tools, adding query validation for other data sources that use a Lezer parser could be trivial, so I quickly came up with this PR, where:
If we want to support other data sources and be friendly with external data sources, we should ideally move this to an external repo.
Special notes for your reviewer:
Demo.mov