-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Validation: accept any parser to validate query and integrate with Prom query editor #77081
Conversation
@grafana/observability-metrics Would you be interested in this feature? I wouldn't mind moving it elsewhere where other data sources could use this. |
Backend code coverage report for PR #77081 |
Frontend code coverage report for PR #77081
|
This is a good refactor and a win IMO even if we don't pursue a shared lib |
I agree @gtk-grafana, this looks good to me! |
c38c711
to
923c36d
Compare
Added unit tests for PromQL. Any concern about merging this @gtk-grafana @bohandley ? |
Thank you all! If there's any issue with this feel free to just ping 👍 |
…grate with Prom query editor
We have a lot of components in common, with similar tools, adding query validation for other data sources that use a Lezer parser could be trivial, so I quickly came up with this PR, where:
If we want to support other data sources and be friendly with external data sources, we should ideally move this to an external repo.
Special notes for your reviewer:
Demo.mov