Gauges: Fixing broken auto sizing #79926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
Develer,
adela-almasan,
Clarity-89,
L-M-K-B and
sunker
and removed request for
a team
torkelo
changed the title
torkelo
requested review from
nmarrs
and removed request for
Eve832,
adela-almasan,
Clarity-89,
L-M-K-B and
sunker
grafana-pr-automation
bot
added
area/panel/gauge
area/frontend
type/docs
torkelo
removed
type/docs
grafana-pr-automation
bot
added
type/docs
Develer
approved these changes
Jan 2, 2024
nmarrs
approved these changes
Jan 2, 2024
2 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
(cherry picked from commit 9126dbc)
3 tasks
nmarrs
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76042 broke the auto sizing option (which is the default and used by almost all panels as manual sizing is very new).
#76216 also caused same issue with Gauge Panel.
I think there are more unfixed bugs here. The BarGaugePanel is showing the "sizing mode" option even when orientation is auto (Gauge panels do not).
It's a bit sad, if we had only tested the gdev panel test dashboard we would have seen a huge change, all panels getting scrollbars. We really need automated visual regression testing :)
Current main:
How it looked before (should look):
Fixes #79797