Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.0.x] Alerting: Make hovercard accessible #86272

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 90a1e8a from #85195


What is this feature?

Prior to this PR the hover card wouldn't be keyboard accessible, this adds the ability to focus the element with the keyboard and it will automatically show the tooltip.

Tested this with Chrome but should also work for the other browsers :)

image

@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner April 16, 2024 09:07
@grafana-delivery-bot grafana-delivery-bot bot requested review from gillesdemey, tomratcliffe, konrad147 and soniaAguilarPeiron and removed request for a team April 16, 2024 09:07
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 16, 2024
@grafana-delivery-bot grafana-delivery-bot bot added area/alerting Grafana Alerting area/frontend backport A backport PR no-changelog Skip including change in changelog/release notes product-approved Pull requests that are approved by product/managers and are allowed to be backported type/accessibility Accessibility problem / enhancement labels Apr 16, 2024
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot 🤖

@ashharrison90 ashharrison90 merged commit 45b18cb into v11.0.x Apr 16, 2024
27 checks passed
@ashharrison90 ashharrison90 deleted the backport-85195-to-v11.0.x branch April 16, 2024 11:30
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Grafana Alerting area/frontend backport A backport PR no-changelog Skip including change in changelog/release notes product-approved Pull requests that are approved by product/managers and are allowed to be backported type/accessibility Accessibility problem / enhancement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants