-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Echo: Suppress errors from frontend-metrics API call failing #89379
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
joshhunt
requested review from
tskarhed and
JoaoSilvaGrafana
and removed request for
a team
June 18, 2024 19:50
tskarhed
approved these changes
Jun 19, 2024
joshhunt
changed the title
Echo: Don't notify if PerformanceBackend errors when flushing
Echo: Suppress errors from frontend-metrics API call failing
Jun 19, 2024
joshhunt
added
add to changelog
and removed
no-changelog
Skip including change in changelog/release notes
labels
Jun 19, 2024
joshhunt
added
backport v11.0.x
Mark PR for automatic backport to v11.0.x
backport v11.1.x
Mark PR for automatic backport to v11.1.x
labels
Jun 20, 2024
joshhunt
added
type/bug
backport v11.0.x
Mark PR for automatic backport to v11.0.x
backport v11.1.x
Mark PR for automatic backport to v11.1.x
and removed
missing-labels
backport v11.0.x
Mark PR for automatic backport to v11.0.x
backport v11.1.x
Mark PR for automatic backport to v11.1.x
labels
Jun 20, 2024
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Loading
Loading status checks…
(cherry picked from commit b434116)
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Loading
Loading status checks…
(cherry picked from commit b434116)
joshhunt
added
backport v10.3.x
Mark PR for automatic backport to v10.3.x
backport v10.4.x
labels
Jun 20, 2024
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Loading
Loading status checks…
(cherry picked from commit b434116)
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Loading
Loading status checks…
(cherry picked from commit b434116)
joshhunt
added a commit
that referenced
this pull request
Jun 20, 2024
Loading
Loading status checks…
joshhunt
added a commit
that referenced
this pull request
Jun 20, 2024
Loading
Loading status checks…
joshhunt
added a commit
that referenced
this pull request
Jun 21, 2024
Loading
Loading status checks…
joshhunt
added a commit
that referenced
this pull request
Jun 21, 2024
Loading
Loading status checks…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/frontend
backport v10.3.x
Mark PR for automatic backport to v10.3.x
backport v10.4.x
backport v11.0.x
Mark PR for automatic backport to v11.0.x
backport v11.1.x
Mark PR for automatic backport to v11.1.x
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses the error toast from PerformanceBackend flushing, as this API is non-critical (it just sends web vitals).
Another reason why I don't think errors should automatically toast.
Fixes #89378