Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo: Suppress errors from frontend-metrics API call failing #89379

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

joshhunt
Copy link
Contributor

@joshhunt joshhunt commented Jun 18, 2024

Suppresses the error toast from PerformanceBackend flushing, as this API is non-critical (it just sends web vitals).

Another reason why I don't think errors should automatically toast.

Fixes #89378

@joshhunt joshhunt requested a review from a team as a code owner June 18, 2024 19:50
@joshhunt joshhunt requested review from tskarhed and JoaoSilvaGrafana and removed request for a team June 18, 2024 19:50
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.2.x milestone Jun 18, 2024
@joshhunt joshhunt added the no-changelog Skip including change in changelog/release notes label Jun 18, 2024
@joshhunt joshhunt merged commit b434116 into main Jun 19, 2024
29 checks passed
@joshhunt joshhunt deleted the joshhunt/suppress-perf-backend-flush-error branch June 19, 2024 09:00
@joshhunt joshhunt changed the title Echo: Don't notify if PerformanceBackend errors when flushing Echo: Suppress errors from frontend-metrics API call failing Jun 19, 2024
@joshhunt joshhunt added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Jun 19, 2024
@joshhunt joshhunt added backport v11.0.x Mark PR for automatic backport to v11.0.x backport v11.1.x Mark PR for automatic backport to v11.1.x labels Jun 20, 2024
@joshhunt joshhunt added type/bug backport v11.0.x Mark PR for automatic backport to v11.0.x backport v11.1.x Mark PR for automatic backport to v11.1.x and removed missing-labels backport v11.0.x Mark PR for automatic backport to v11.0.x backport v11.1.x Mark PR for automatic backport to v11.1.x labels Jun 20, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Jun 20, 2024
(cherry picked from commit b434116)
grafana-delivery-bot bot pushed a commit that referenced this pull request Jun 20, 2024
(cherry picked from commit b434116)
@grafana grafana deleted a comment from grafana-delivery-bot bot Jun 20, 2024
@grafana grafana deleted a comment from grafana-delivery-bot bot Jun 20, 2024
@joshhunt joshhunt added backport v10.3.x Mark PR for automatic backport to v10.3.x backport v10.4.x labels Jun 20, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Jun 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
(cherry picked from commit b434116)
grafana-delivery-bot bot pushed a commit that referenced this pull request Jun 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
(cherry picked from commit b434116)
joshhunt added a commit that referenced this pull request Jun 20, 2024
#89493)

Echo: Don't notify if PerformanceBackend errors when flushing (#89379)

(cherry picked from commit b434116)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
joshhunt added a commit that referenced this pull request Jun 20, 2024
#89494)

Echo: Don't notify if PerformanceBackend errors when flushing (#89379)

(cherry picked from commit b434116)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
joshhunt added a commit that referenced this pull request Jun 21, 2024
#89497)

Echo: Don't notify if PerformanceBackend errors when flushing (#89379)

(cherry picked from commit b434116)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
joshhunt added a commit that referenced this pull request Jun 21, 2024
#89498)

Echo: Don't notify if PerformanceBackend errors when flushing (#89379)

(cherry picked from commit b434116)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
@aangelisc aangelisc modified the milestones: 11.2.x, 11.2.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend backport v10.3.x Mark PR for automatic backport to v10.3.x backport v10.4.x backport v11.0.x Mark PR for automatic backport to v11.0.x backport v11.1.x Mark PR for automatic backport to v11.1.x type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/api/frontend-metrics should not throw a toast when the API fails
3 participants