Allow specifying pvc selectors in the chart #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
requested review from
maorfr,
torstenwalter and
zanhsieh
as code owners
Signed-off-by: George Wilson <george.wilson@automationlogic.com>
zanhsieh
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some on prem datacenter deployments you have static PVs where you match pre-created PVCs/VolumeClaimTemplates to a fixed PV. This allows use of this by optionally allowing users to specify a
labelSelectorfor their persistence.Currently the only real option is to have a single instance where you pass in a pre-created PVC - whilst this is an option for a single instance of grafana - it obviously doesn't work if you want to use a stateful set for multiple instances