[loki-distributed] Add capability to add Volumes and Volume mounts #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>
…readme Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>
Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>
Whyeasy
changed the title
Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>
Whyeasy
changed the title
unguiculus
requested changes
Jan 7, 2021
Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>
unguiculus
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add the capability to add Volumes and Volume mounts to the needed services. This is needed to be able to mount the GCP service account for example.
Benefits
Able to mount the GCP service account json file to the needed services.
Additional Information
It's the same capability as PR #148 but not a global level.