[grafana] image-renderer: fix namespace selector issue #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementnuss
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
fixes grafana#795 removing the `namespaceSelector` from the network policy effectively only allows pods from the same namespace to access the image renderer. there is no need to manually specify the namespace, and the label previously used to match on a namespace isn't the default K8s namespace label (that would be kubernetes.io/metadata.name ) Signed-off-by: Clément Nussbaumer <clement@astutus.org>
zanhsieh
changed the title
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #795
removing the
namespaceSelectorfrom the network policyeffectively only allows pods from the same namespace to access
the image renderer. there is no need to manually specify the
namespace, and the label previously used to match on a namespace
isn't the default K8s namespace label (that would be
kubernetes.io/metadata.name )