[promtail] Add enable service links for Promtail #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TAYTS
force-pushed
the
feat/add-enable-service-links
branch
2 times, most recently
from
7cc51d7
to
cf94022
Compare
zanhsieh
changed the title
TAYTS
force-pushed
the
feat/add-enable-service-links
branch
3 times, most recently
from
881ba90
to
8276d8b
Compare
Signed-off-by: TAYTS <taytzushieh@gmail.com>
Signed-off-by: TAYTS <taytzushieh@gmail.com>
Signed-off-by: TAYTS <taytzushieh@gmail.com>
Signed-off-by: TAYTS <taytzushieh@gmail.com>
TAYTS
force-pushed
the
feat/add-enable-service-links
branch
from
8276d8b
to
682c522
Compare
Signed-off-by: MH <zanhsieh@gmail.com>
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow disable
enableServiceLinksso that the service environments are not injected into the pods where in my scenario Promtail is deployed in the same namespace as the Knative services resulted the Promtail pod unable to start up due to too many service environment being injected.Reference issue for pod unable to startup due to too many services:
standard_init_linux.go:211: exec user process caused "argument list too long"kubernetes/kubernetes#84539 (comment)