Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Explicit volumeClaimTemplate kind/apiVersion #2116

Closed
wants to merge 1 commit into from

Conversation

sathieu
Copy link

@sathieu sathieu commented Jan 12, 2023

Otherwise, I'm having a diff in ArgoCD:

     type: RollingUpdate
   volumeClaimTemplates:
-    - apiVersion: v1
-      kind: PersistentVolumeClaim
-      metadata:
+    - metadata:
        creationTimestamp: null
        name: storage

Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2023

CLA assistant check
All committers have signed the CLA.

@zanhsieh
Copy link
Collaborator

@sathieu
Could you provide more strong support that VolumeClaimTemplates could take explicit PVC syntax? I only could find this the official k8s documentation:

https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#components

It does not support explicit PVC syntax.

@sathieu
Copy link
Author

sathieu commented Jan 16, 2023

@zanhsieh You are right. This is probably a bug in ArgoCD. Will try again with the latest ArgoCD version.

@sathieu
Copy link
Author

sathieu commented Jan 17, 2023

This is argoproj/argo-cd#11143.

Closing.

@sathieu sathieu closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants