[grafana] support templating grafana ini options #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbetter173
requested review from
maorfr,
torstenwalter and
zanhsieh
as code owners
bbetter173
changed the title
bbetter173
changed the title
bbetter173
changed the title
…l templating. Signed-off-by: Ben Bettridge <bbettridge@switch.tv>
Signed-off-by: Ben Bettridge <bbettridge@switch.tv>
Signed-off-by: Ben Bettridge <bbettridge@switch.tv>
bbetter173
force-pushed
the
feature/grafana-config-tpl
branch
from
786b94e to
8b5a1fa
Compare
zanhsieh
approved these changes
Mar 1, 2021
|
Hi folks - commenting here but we could probably chat over in #335 - I'm curious why this change was merged with no updates to documentation? This broke the documented method of how to insert the grafana.ini into the values.yaml, which is causing issues for me. I don't mind changing my values if the documentation in this repo is updated to align with the purpose of this change. Thanks! Edit: would still like to see some documentation on this, but after doing some more digging this PR actually exposed an invalid configuration that wasn't erroring out for me before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the same issue as #201 but works.
Only difference in output is whitespace output when nil values are supplied.