[loki-distributed] [bug] wrong indent for server config #3459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
The
server
configuration in the Helm template was being incorrectly indented due to the use of an absolute indentation level (nindent 6
). This caused issues when the server field and its nested configuration were parsed into a Go map and then re-generated as YAML. Since the indentation in YAML is relative to the parent field, using an absolute indentation level resulted in malformed YAML output.Here is Configmap template
You can see other case similer in
values.yaml
fileTesting
Verified that the generated YAML now has the correct relative indentation under the server field.
Ensured that the fix does not introduce any regression in other parts of the configuration.