Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo] Add topologySpreadConstraints #3460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rim99
Copy link

@rim99 rim99 commented Nov 29, 2024

Add topologySpreadConstraints, so pods can spread in multiple AZs or regions evenly

Signed-off-by: rim99 <zhangxin@outlook.com>
@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

@rim99 rim99 marked this pull request as ready for review November 29, 2024 03:54
@Sheikh-Abubaker Sheikh-Abubaker added the enhancement New feature or request label Dec 7, 2024
Signed-off-by: rim99 <zhangxin@outlook.com>
@rim99 rim99 force-pushed the tempo_add_topology_spread_constraints branch from 3f02ea4 to 89c0c27 Compare December 9, 2024 12:00
@rim99
Copy link
Author

rim99 commented Dec 9, 2024

Hey @Sheikh-Abubaker, I've updated this PR as the linter suggested. Would you like to review this?

@joe-elliott
Copy link
Member

isn't this a single binary helm chart? do topology constraints impact a single pod statefulset?

@rim99
Copy link
Author

rim99 commented Dec 9, 2024

@joe-elliott I think this can be tuned to be a statefulset with mutiple pods.
I've created a small cluster with several pods in my environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants