Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Time Range does not account for pagination #315

Open
chejimmy opened this issue Jun 4, 2024 · 2 comments
Open

Expand Time Range does not account for pagination #315

chejimmy opened this issue Jun 4, 2024 · 2 comments
Labels
datasource/Sitewise type/bug Something isn't working

Comments

@chejimmy
Copy link
Contributor

chejimmy commented Jun 4, 2024

What happened:

When the request paginating, the last observation (last data point before the time range) is also returned. However, when time series panel renders, it creates an extra line across the panel.

Related code https://github.com/grafana/iot-sitewise-datasource/blob/main/pkg/server/last-observation.go#L54C27-L54C41

What you expected to happen:

No last observation added to paginating request.

How to reproduce it (as minimally and precisely as possible):

  1. add a query with Expand Time Range support
  2. add an asset + property
  3. enable Expand Time Range
  4. select time range greater than 6 hour or any other ways to make query to paginate
  5. notice there's a line across the very first data point and the start of the second page of the data

Screenshots

See comment #315 (comment)

Anything else we need to know?:

Environment:

  • Grafana version: 9.4 (or any)
  • Plugin version: since "Expand Time Range" support
  • OS Grafana is installed on: N/A
  • User OS & Browser: MacOS 14.3 (23D56) / Google Chrome Version 125.0.6422.112
  • Others:
@chejimmy chejimmy added datasource/Sitewise type/bug Something isn't working labels Jun 4, 2024
@chejimmy
Copy link
Contributor Author

chejimmy commented Jun 4, 2024

Screen.Recording.2024-06-04.at.11.16.52.AM.mov

@idastambuk
Copy link
Contributor

Hi @chejimmy thanks for reporting this! I've managed to reproduce it and will add it to our pipeline

@idastambuk idastambuk moved this from Incoming to Next in AWS Datasources Jun 5, 2024
@katebrenner katebrenner moved this from Next to Backlog in AWS Datasources Jun 24, 2024
@idastambuk idastambuk moved this from Waiting to Backlog in AWS Datasources Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/Sitewise type/bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants