fix: add check for nil for property value #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssjagad
requested review from
iwysiu and
nmarrs
and removed request for
a team
hwandersman
approved these changes
Sep 18, 2024
iwysiu
approved these changes
Sep 18, 2024
|
There are ci errors that i have a pr up for: #353 and I'll merge it after those go in |
ssjagad
force-pushed
the
null_NaN_fix
branch
from
56d5f78
to
87c7afa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, get property value and get property history error out when you query on a an asset with null or mixed value (null + value). We want to ensure make sure our experience is error free.
Which issue(s) this PR fixes:
Ensures that get property value and get property history to BAD or UNCERTAIN data is error free.
Screen.Recording.2024-09-18.at.9.07.10.AM.mov
Fixes #
Special notes for your reviewer: