Fix #9: RandomController conversion generating out-of-bounds indexes

grafana · Feb 27, 2019 · 660ab68 · 660ab68
1 parent fd9c04e
commit 660ab68
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/element/RandomController.js b/src/element/RandomController.js
@@ -79,7 +79,7 @@ ${ind(strip(logic))}
   }
   result.logic = `\n\n`
   if (settings.comment) result.logic += `/* ${settings.comment} */\n`
-  const index = `Math.floor(Math.random()*(${blocks.length}+1))`
+  const index = `Math.floor(Math.random()*(${blocks.length}))`
   result.logic += '' +
 `{ const index = ${index}; switch (index) {
 ${ind(blocks.join('\n'))}

diff --git a/test/int/element/RandomController.js b/test/int/element/RandomController.js
@@ -15,7 +15,7 @@ test('convert', t => {
   const result = RandomController(node)
   t.is(result.logic, `
 
-{ const index = Math.floor(Math.random()*(3+1)); switch (index) {
+{ const index = Math.floor(Math.random()*(3)); switch (index) {
   case 0:
     // Fake
     break