feat: add helmraiser & a generated cert-manager lib from the chart #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/helmraiser_initial_release
branch
from
e4e9399 to
9ec99b9
Compare
Duologic
changed the title
RichiH
reviewed
Aug 6, 2020
| set +u | ||
| OVERWRITTEN=false | ||
| if [ "$3" = "overwrite" ] || [ "$4" = "overwrite" ]; then | ||
| rm -rf $OUTPUT_DIR/templates |
There was a problem hiding this comment.
helmraiser.sh foo "/home/* ." would be fun, wouldn't it?
There was a problem hiding this comment.
That would be awesome. Luckily this is regarded a PoC and should be used with care.
How would you solve this? cd into it first?
|
Sorry, I thought I had submitted this days ago. Seems it was stuck. |
|
https://github.com/RichiH/vcsh/blob/master/vcsh is painstakingly
escaped with the best POSIX principles and can serve as a template.
The specific question's answer, you have two ways:
rm -rf "$OUTPUT_DIR"/templates
rm -rf "$OUTPUT_DIR/templates"
…On Fri, Aug 7, 2020 at 8:37 AM Duologic ***@***.***> wrote:
@Duologic commented on this pull request.
________________________________
In scripts/helmraiser/helmraiser.sh:
> +IFS=$'\n\t'
+
+DIRNAME=$(dirname $0)
+if [ "$#" != 2 ] && [ "$#" != 3 ]&& [ "$#" != 4 ]; then
+ >&2 echo "arguments invalid"
+ echo "Usage: `basename $0` <path to helm chart> <output dir> ['<helm_args>'] [overwrite]"
+ exit 1
+fi
+
+HELMCHART=$1
+OUTPUT_DIR=$2
+
+set +u
+OVERWRITTEN=false
+if [ "$3" = "overwrite" ] || [ "$4" = "overwrite" ]; then
+ rm -rf $OUTPUT_DIR/templates
That would be awesome. Luckily this is regarded a PoC and should be used with care.
How would you solve this? cd into it first?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Ugh, pretend I can English...
|
Duologic
force-pushed
the
duologic/helmraiser_initial_release
branch
from
97b7f26 to
3ee4fc6
Compare
|
Should get replaced by #320 once grafana/tanka#336 is merged and in a release. |
Duologic
added a commit
that referenced
this pull request
Aug 18, 2020
Duologic
added a commit
that referenced
this pull request
Aug 18, 2020
Duologic
added a commit
that referenced
this pull request
Aug 24, 2020
Duologic
added a commit
that referenced
this pull request
Aug 25, 2020
* Update helm.libsonnet (#331) * refactor(cert-manager): install with helmraiser Closes #315, #318, #320 * name port to http-metrics so it gets scraped * allow to specify vendor folder * don't install crds from 2 sources * cert-manager: add readme * correct $._config name * docs(cert-manager): add inline comments Co-authored-by: sh0rez <me@shorez.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the README
Commits can be reviewed individually.