Skip to content

Postgres-mixin: Bugfixes and linting #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

rgeyer
Copy link
Contributor

@rgeyer rgeyer commented May 18, 2022

Some changes to accommodate the dashboard linter, caught several minor (or moderate?) issues.

  • Most (all?) queries were not using the $job matcher
  • The template vars were set with default selected values, which weren't ideal
  • The instance template var was not filtering to instances belonging to the selected job(s)

rgeyer added 3 commits May 18, 2022 15:00
…er to properly parse them. Gotta look into that.

Update template vars to appropriate values and multiselect
@v-zhuravlev
Copy link
Contributor

What do you think, should we switch to upsteam?
#726

@rgeyer
Copy link
Contributor Author

rgeyer commented May 23, 2022

What do you think, should we switch to upsteam? #726

Ohh yes! Good call.. I totally spaced on that. I'll offer these changes as an upstream PR instead. :)

@rgeyer
Copy link
Contributor Author

rgeyer commented May 25, 2022

Closing in favor of prometheus-community/postgres_exporter#647

@rgeyer rgeyer closed this May 25, 2022
@nikimanoledaki nikimanoledaki deleted the rgeyer/postgres-linting branch March 19, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants